[Driver][NFC][FPGA] Remove remaining FPGA offload support in driver #18087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following intel@491915b, remove the remaining items in the driver that support FPGA. Small exceptions to this include any specific diagnostic behaviors that inform the user of option usage that is not supported due to the removal of FPGA. Cleanup of those items can occur following a later major release. The extension enabling options for the `sycl-post-link` tool specific for fpga also remain for now.
asudarsa
reviewed
Apr 18, 2025
asudarsa
reviewed
Apr 18, 2025
asudarsa
reviewed
Apr 18, 2025
| if (!Args.hasFlag(options::OPT_fsycl_early_optimizations, | ||
| options::OPT_fno_sycl_early_optimizations, | ||
| !IsFPGASYCLOffloadDevice)) | ||
| options::OPT_fno_sycl_early_optimizations, true)) |
There was a problem hiding this comment.
Are we doing 'no early optimizations' for any other target?
Thanks
There was a problem hiding this comment.
Not that I know of. But we should keep the logic in case somebody asks for it on the command line.
asudarsa
reviewed
Apr 18, 2025
asudarsa
reviewed
Apr 18, 2025
asudarsa
reviewed
Apr 18, 2025
asudarsa
requested changes
Apr 18, 2025
srividya-sundaram
approved these changes
Apr 21, 2025
|
@intel/llvm-gatekeepers , this is ready for merge, thanks! |
vinser52
pushed a commit
to sergey-semenov/llvm
that referenced
this pull request
Apr 22, 2025
…ntel#18087) Following intel@491915b, remove the remaining items in the driver that support FPGA. Small exceptions to this include any specific diagnostic behaviors that inform the user of option usage that is not supported due to the removal of FPGA. Cleanup of those items can occur following a later major release. The extension enabling options for the `sycl-post-link` tool specific for fpga also remain for now.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following 491915b, remove the remaining items in the driver that support FPGA.
Small exceptions to this include any specific diagnostic behaviors that inform the user of option usage that is not supported due to the removal of FPGA. Cleanup of those items can occur following a later major release. The extension enabling options for the
sycl-post-linktool specific for fpga also remain for now.